Fix the information_schema queries.#37
Open
tekkamanendless wants to merge 3 commits intogo-gorm:masterfrom
Open
Fix the information_schema queries.#37tekkamanendless wants to merge 3 commits intogo-gorm:masterfrom
tekkamanendless wants to merge 3 commits intogo-gorm:masterfrom
Conversation
BigQuery requires that `information_schema` queries include the dataset name. This fixes the various Migrator methods to do this.
greg-threatmate
approved these changes
Dec 23, 2025
Member
|
Could we avoid making BigQueryConnection a public struct? |
Author
|
@jinzhu unfortunately, we need to be able to get the dataset from the connection in the main package in For example, we use it with We could potentially expose a public interface that has |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigQuery requires that
information_schemaqueries include the dataset name. This fixes the various Migrator methods to do this.This fixes #17.